modules: hal_nordic: Add multi-instance DPPI and PPIB drivers #79857 #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
NordicBuilder
requested review from
hubertmis,
jaz1-nordic,
kl-cruz,
krish2718,
magp-nordic,
masz-nordic,
nika-nordic,
nordic-krch,
rajb9,
sachinthegreen,
srkanordic and
udaynordic
e-rk
force-pushed
the
hal-nordic-update
branch
2 times, most recently
from
87735e7 to
d707d70
Compare
e-rk
force-pushed
the
hal-nordic-update
branch
2 times, most recently
from
c59defd to
98584dd
Compare
e-rk
force-pushed
the
hal-nordic-update
branch
3 times, most recently
from
e188fd0 to
62c66d3
Compare
e-rk
force-pushed
the
hal-nordic-update
branch
from
62c66d3 to
fb62938
Compare
The hal_nordic revision was updated to bring in NRFX v3.8.0. Aligned the uses of single-instance API to use multi-instance instead. Signed-off-by: Rafał Kuźnia <[email protected]> (cherry picked from commit d600769)
Added a binding description for the PPIB peripheral and added the device tree nodes of the PPIB instances to the nRF54L15 and nRF54L20. Signed-off-by: Rafał Kuźnia <[email protected]> (cherry picked from commit 61d7293)
The new nrfx_ppib driver can now be enabled, when the corrensponding device tree node has the okay status. Signed-off-by: Rafał Kuźnia <[email protected]> (cherry picked from commit bf66012)
This reverts commit 84f9753. Signed-off-by: Rafał Kuźnia <[email protected]>
…or NRFE" This reverts commit 1265858. Signed-off-by: Rafał Kuźnia <[email protected]>
The resource reservation definitions were moved to a separate header file. The PPIB and DPPI channel and group resources can now be statically allocated for each individual instance. Signed-off-by: Rafał Kuźnia <[email protected]> (cherry picked from commit 40d9dae)
The nrfx_gppi module is an abstraction over nrfx_ppi and nrfx_dppi drivers. It now has a Kconfig option that is separate from nrfx_dppi and by default it enables all PPI/DPPI instances, if available. Signed-off-by: Rafał Kuźnia <[email protected]> (cherry picked from commit e184109)
e-rk
force-pushed
the
hal-nordic-update
branch
2 times, most recently
from
7fa6150 to
4d92f64
Compare
…ader The resource reservation header is now included according to a Kconfig value. The Kconfig can be overriden out-of-tree in case a different header is needed. Upstream PR #: 81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
force-pushed
the
hal-nordic-update
branch
from
4d92f64 to
0d17b8d
Compare
…RIES The NRF54L_SERIES define is more specific and should be used in favor of LUMOS_XXAA. Upstream PR #: 81602 Signed-off-by: Rafał Kuźnia <[email protected]>
Added dppic0 node label, alongside the dppic to maintain backward compatibility. The use of dppic0 is preferred. Upstream PR #: 81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
force-pushed
the
hal-nordic-update
branch
from
0d17b8d to
1135c0c
Compare
ankuns
reviewed
Nov 20, 2024
| #if defined(NRF53_SERIES) | ||
| #define NRFX_DPPI0_CHANNELS_USED_BY_BT_CTLR BT_CTLR_USED_PPI_CHANNELS | ||
| #define NRFX_DPPI0_GROUPS_USED_BY_BT_CTLR BT_CTLR_USED_PPI_GROUPS | ||
| #elif defined(LUMOS_XXAA) |
There was a problem hiding this comment.
As you changed LUMOS_XXAA to NRF54L_SERIES, you can do it here also.
ankuns
reviewed
Nov 20, 2024
Comment on lines
+664
to
+666
| #define NRFX_DPPI0_CHANNELS_USED \ | ||
| (NRFX_DPPI0_CHANNELS_USED_BY_BT_CTLR | NRFX_DPPI0_CHANNELS_USED_BY_802154_DRV | \ | ||
| NRFX_DPPI0_CHANNELS_USED_BY_MPSL) |
There was a problem hiding this comment.
Just a question: Is handling of CONFIG_NRFE not needed anymore (in general, not in this particular place)? @kl-cruz opinion?
There was a problem hiding this comment.
The NRFE reservations are empty for now. I decided to leave them out and talk to Magdalena afterwards.
Added ncs-specific modules to nrfx_config_reserved_resources. The modules are: - mpsl - nrfe Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
force-pushed
the
hal-nordic-update
branch
from
1135c0c to
45a3713
Compare
ankuns
approved these changes
Nov 20, 2024
nika-nordic
approved these changes
Nov 20, 2024
|
@masz-nordic I'm intending to bring it back soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multi-instance DPPI driver and a new PPIB driver.
Cherry-picks from upstream.